Contribution guide to document actual guide for pull requests#378
Contribution guide to document actual guide for pull requests#378khalidmammadov wants to merge 6 commits intoapache:asf-sitefrom
Conversation
contributing.md
Outdated
| <a href="https://github.com/apache/spark">https://github.com/apache/spark</a> if you haven't already | ||
| 1. Clone your fork, create a new branch, push commits to the branch. | ||
| 1. Consider whether documentation or tests need to be added or updated as part of the change, | ||
| 2. Go to "Actions" tab on your forked repository and enable "Build and test" and "Report test results" workflows |
There was a problem hiding this comment.
Just write 1. on each of these and revert subsequent changes. The point is that markdown generates the correct numbering
contributing.md
Outdated
| tested with a comment like "Jenkins, add to whitelist" | ||
| 1. After about 2 hours, Jenkins will post the results of the test to the pull request, along | ||
| 10. The Jenkins automatic pull request builder will test your changes | ||
| 1. If it is your first contribution, Jenkins will wait for confirmation before building |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
This looks like mostly straight-forward moving the content from developer-tools page to contributing page. Could you make it clear in the PR title and description about what was copied and what was newly revised and added, @khalidmammadov ?
If you don't mind, please update the corresponding JIRA too.
|
A little more detail in the description would be nice; we don't need a JIRA for this website change I think |
To @srowen: Yes, I agree with you that we don't need a JIRA for this website change. However, @khalidmammadov already filed SPARK-37996 on January 24th as he described in the AS-IS PR description. That's the reason why I asked him to update it. |
HyukjinKwon
left a comment
There was a problem hiding this comment.
Yeah, updating PR / JIRA descriptions would be great. Otherwise, it looks fine to me 2/
|
I think all done, anything left to do here? |
Currently contribution guide does not reflect actual flow to raise a new PR and hence it's not clear (for a new contributors) what exactly needs to be done to make a PR for Spark repository and test it as per expectation. This PR addresses that by following:
Tested imperically with
bundle exec jekyll serveand static files were generated withbundle exec jekyll buildcommandsThis closes https://issues.apache.org/jira/browse/SPARK-37996